Pad to a whole number of bytes when encoding bit arrays #751
+80
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-viney
force-pushed
the
bit-array-encode-padding
branch
from
0b6aab6
to
2ad488e
Compare
|
Closed in favour of #754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #750.
My main hesitation with this change is that a round trip isn't stable, i.e.
bit array -> encode to base 64 string -> decode to bit arraydoesn't give you back what you started with.But in practice that's probably not going to cause many problems for people.
This PR also removes
bit_array_int_to_u32andbit_array_int_from_u32fromgleam_stdlib.erlas I couldn't find any reference to them anywhere in the stdlib or compiler. They look to be leftover from some helper functions that were removed a long time ago.