Avoid MANIFEST_TREE_CACHE growing indefinitely during changeset impor…

…t phase
glandium · Nov 13, 2023 · 90c324a · 90c324a
1 parent 3a0c5bf
commit 90c324a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/cinnabar/manifest.rs b/src/cinnabar/manifest.rs
@@ -59,7 +59,9 @@ impl GitManifestTree {
             let queries_limit = cmp::max(100, lru_cache.len() / 2);
             if *queries >= queries_limit {
                 let miss_rate = *misses / (*queries / 10);
-                if (lru_cache.cap() == NonZeroUsize::MAX) || miss_rate >= 7 {
+                // Avoid growing the cache when we're flat-lining at 100% miss rate.
+                if (lru_cache.cap() == NonZeroUsize::MAX) || (miss_rate >= 7 && *misses != *queries)
+                {
                     lru_cache.resize(
                         NonZeroUsize::new(lru_cache.len() + lru_cache.len() / 2 + 1).unwrap(),
                     );