Move remains of do_set to Rust #1050
Annotations
5 errors and 6 warnings
src/store.rs#L1173
error: using `clone` on type `CommitId` which implements the `Copy` trait
--> src/store.rs:1173:56
|
1173 | unsafe { &mut hg2git }.add_note(hg_id, commit.clone().into());
| ^^^^^^^^^^^^^^ help: try dereferencing it: `(*commit)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
|
src/store.rs#L1355
error: using `clone` on type `CommitId` which implements the `Copy` trait
--> src/store.rs:1355:69
|
1355 | while let Some(existing_hg_id) = GitChangesetId::from_unchecked(git_id.clone()).to_hg() {
| ^^^^^^^^^^^^^^ help: try dereferencing it: `*git_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
src/store.rs#L1363
error: useless conversion to the same type: `git::commit::CommitId`
--> src/store.rs:1363:51
|
1363 | buf.extend_from_slice(RawCommit::read(git_id.clone().into()).unwrap().as_bytes());
| ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `git_id.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
|
src/store.rs#L1363
error: using `clone` on type `CommitId` which implements the `Copy` trait
--> src/store.rs:1363:51
|
1363 | buf.extend_from_slice(RawCommit::read(git_id.clone().into()).unwrap().as_bytes());
| ^^^^^^^^^^^^^^ help: try dereferencing it: `(*git_id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/implicit.rs#L17
warning: unused import: `removed_by_x9`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/implicit.rs:17:41
|
17 | use super::prepare::{not_removed_by_x9, removed_by_x9, IsolatingRunSequence};
| ^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/prepare.rs#L170
warning: method `text_range` is never used
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/prepare.rs:170:19
|
168 | impl IsolatingRunSequence {
| ------------------------- method in this implementation
169 | /// Returns the full range of text represented by this isolating run sequence
170 | pub(crate) fn text_range(&self) -> Range<usize> {
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro-error-1.0.4/src/lib.rs#L472
warning: panic message is not a string literal
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro-error-1.0.4/src/lib.rs:472:12
|
472 | panic!(AbortNow)
| ------ ^^^^^^^^
| |
| help: use std::panic::panic_any instead: `std::panic::panic_any`
|
= note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
= note: `#[warn(non_fmt_panics)]` on by default
|
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crc32fast-1.3.2/src/specialized/pclmulqdq.rs#L147
warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crc32fast-1.3.2/src/specialized/pclmulqdq.rs:147:5
|
147 | drop(K6);
| ^^^^^--^
| |
| argument has type `i64`
|
= note: use `let _ = ...` to ignore the expression or result
= note: `#[warn(dropping_copy_types)]` on by default
|
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tee-0.1.0/src/lib.rs#L27
warning: use of deprecated macro `try`: use the `?` operator instead
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tee-0.1.0/src/lib.rs:27:9
|
27 | try!(self.writer.write_all(&buf[..n]));
| ^^^
|
= note: `#[warn(deprecated)]` on by default
|
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tee-0.1.0/src/lib.rs#L26
warning: use of deprecated macro `try`: use the `?` operator instead
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tee-0.1.0/src/lib.rs:26:17
|
26 | let n = try!(self.reader.read(buf));
| ^^^
|
The logs for this run have expired and are no longer available.
Loading