Fix clippy warnings from rustc 1.73 #978
Annotations
11 errors and 18 warnings
test (ubuntu-latest, 1.71.0)
Process completed with exit code 101.
|
the trait bound `std::boxed::Box<bstr::BStr>: std::borrow::Borrow<&bstr::BStr>` is not satisfied:
src/main.rs#L3500
error[E0277]: the trait bound `std::boxed::Box<bstr::BStr>: std::borrow::Borrow<&bstr::BStr>` is not satisfied
--> src/main.rs:3500:56
|
3500 | .filter(|(h, b)| branch_names.contains(b))
| -------- ^ the trait `std::borrow::Borrow<&bstr::BStr>` is not implemented for `std::boxed::Box<bstr::BStr>`
| |
| required by a bound introduced by this call
|
= help: the trait `std::borrow::Borrow<T>` is implemented for `std::boxed::Box<T, A>`
note: required by a bound in `std::collections::HashSet::<T, S>::contains`
--> /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/std/src/collections/hash/set.rs:670:5
|
clippy (ubuntu-latest, 1.71.0)
Clippy had exited with the 101 exit code
|
test (ubuntu-latest, 1.66.0)
Process completed with exit code 101.
|
test (macos-latest, 1.71.0)
Process completed with exit code 101.
|
the trait bound `std::boxed::Box<bstr::BStr>: std::borrow::Borrow<&bstr::BStr>` is not satisfied:
src/main.rs#L3500
error[E0277]: the trait bound `std::boxed::Box<bstr::BStr>: std::borrow::Borrow<&bstr::BStr>` is not satisfied
--> src/main.rs:3500:56
|
3500 | .filter(|(h, b)| branch_names.contains(b))
| -------- ^ the trait `std::borrow::Borrow<&bstr::BStr>` is not implemented for `std::boxed::Box<bstr::BStr>`
| |
| required by a bound introduced by this call
|
= help: the trait `std::borrow::Borrow<T>` is implemented for `std::boxed::Box<T, A>`
note: required by a bound in `std::collections::HashSet::<T, S>::contains`
--> /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/std/src/collections/hash/set.rs:670:5
|
clippy (macos-latest, 1.71.0)
Clippy had exited with the 101 exit code
|
test (macos-latest, 1.66.0)
Process completed with exit code 101.
|
test (windows-latest, 1.66.0-x86_64-pc-windows-gnu)
Process completed with exit code 1.
|
clippy (windows-latest, 1.71.0-x86_64-pc-windows-gnu)
Clippy had exited with the 101 exit code
|
test (windows-latest, 1.71.0-x86_64-pc-windows-gnu)
Process completed with exit code 1.
|
panic message is not a string literal:
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro-error-1.0.4/src/lib.rs#L472
warning: panic message is not a string literal
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro-error-1.0.4/src/lib.rs:472:12
|
472 | panic!(AbortNow)
| ------ ^^^^^^^^
| |
| help: use std::panic::panic_any instead: `std::panic::panic_any`
|
= note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
= note: `#[warn(non_fmt_panics)]` on by default
|
unused import: `removed_by_x9`:
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/implicit.rs#L17
warning: unused import: `removed_by_x9`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/implicit.rs:17:41
|
17 | use super::prepare::{not_removed_by_x9, removed_by_x9, IsolatingRunSequence};
| ^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
method `text_range` is never used:
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/prepare.rs#L170
warning: method `text_range` is never used
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/prepare.rs:170:19
|
168 | impl IsolatingRunSequence {
| ------------------------- method in this implementation
169 | /// Returns the full range of text represented by this isolating run sequence
170 | pub(crate) fn text_range(&self) -> Range<usize> {
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
calls to `std::mem::drop` with a value that implements `Copy` does nothing:
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crc32fast-1.3.2/src/specialized/pclmulqdq.rs#L147
warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crc32fast-1.3.2/src/specialized/pclmulqdq.rs:147:5
|
147 | drop(K6);
| ^^^^^--^
| |
| argument has type `i64`
|
= note: use `let _ = ...` to ignore the expression or result
= note: `#[warn(dropping_copy_types)]` on by default
|
use of deprecated constant `libc::ENOATTR`: ENOATTR is not available on Linux; use ENODATA instead:
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/mod.rs#L12
warning: use of deprecated constant `libc::ENOATTR`: ENOATTR is not available on Linux; use ENODATA instead
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/mod.rs:12:56
|
12 | pub const ENOATTR: ::libc::c_int = ::libc::ENOATTR;
| ^^^^^^^
...
37 | / platforms! {
38 | | "android"; "linux"; "macos" => linux_macos,
39 | | "freebsd"; "netbsd" => bsd
40 | | }
| |_- in this macro invocation
|
= note: `#[warn(deprecated)]` on by default
= note: this warning originates in the macro `platforms` (in Nightly builds, run with -Z macro-backtrace for more info)
|
variable does not need to be mutable:
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap-4.0.26/src/builder/command.rs#L4035
warning: variable does not need to be mutable
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap-4.0.26/src/builder/command.rs:4035:17
|
4035 | for mut sc in &mut self.subcommands {
| ----^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
use of deprecated macro `try`: use the `?` operator instead:
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tee-0.1.0/src/lib.rs#L27
warning: use of deprecated macro `try`: use the `?` operator instead
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tee-0.1.0/src/lib.rs:27:9
|
27 | try!(self.writer.write_all(&buf[..n]));
| ^^^
|
= note: `#[warn(deprecated)]` on by default
|
use of deprecated macro `try`: use the `?` operator instead:
home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tee-0.1.0/src/lib.rs#L26
warning: use of deprecated macro `try`: use the `?` operator instead
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tee-0.1.0/src/lib.rs:26:17
|
26 | let n = try!(self.reader.read(buf));
| ^^^
|
panic message is not a string literal:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro-error-1.0.4/src/lib.rs#L472
warning: panic message is not a string literal
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro-error-1.0.4/src/lib.rs:472:12
|
472 | panic!(AbortNow)
| ------ ^^^^^^^^
| |
| help: use std::panic::panic_any instead: `std::panic::panic_any`
|
= note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html>
= note: `#[warn(non_fmt_panics)]` on by default
|
unused import: `removed_by_x9`:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/implicit.rs#L17
warning: unused import: `removed_by_x9`
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/implicit.rs:17:41
|
17 | use super::prepare::{not_removed_by_x9, removed_by_x9, IsolatingRunSequence};
| ^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
method `text_range` is never used:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/prepare.rs#L170
warning: method `text_range` is never used
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unicode-bidi-0.3.13/src/prepare.rs:170:19
|
168 | impl IsolatingRunSequence {
| ------------------------- method in this implementation
169 | /// Returns the full range of text represented by this isolating run sequence
170 | pub(crate) fn text_range(&self) -> Range<usize> {
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
calls to `std::mem::drop` with a value that implements `Copy` does nothing:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crc32fast-1.3.2/src/specialized/pclmulqdq.rs#L147
warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crc32fast-1.3.2/src/specialized/pclmulqdq.rs:147:5
|
147 | drop(K6);
| ^^^^^--^
| |
| argument has type `i64`
|
= note: use `let _ = ...` to ignore the expression or result
= note: `#[warn(dropping_copy_types)]` on by default
|
use of deprecated type alias `libc::uint32_t`: Use u32 instead.:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs#L1
warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead.
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs:1:52
|
1 | use libc::{c_char, c_int, c_void, size_t, ssize_t, uint32_t};
| ^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
use of deprecated type alias `libc::uint32_t`: Use u32 instead.:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs#L26
warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead.
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs:26:23
|
26 | position: uint32_t,
| ^^^^^^^^
|
use of deprecated type alias `libc::uint32_t`: Use u32 instead.:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs#L46
warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead.
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs:46:23
|
46 | position: uint32_t,
| ^^^^^^^^
|
use of deprecated type alias `libc::uint32_t`: Use u32 instead.:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs#L82
warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead.
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs:82:23
|
82 | position: uint32_t,
| ^^^^^^^^
|
use of deprecated type alias `libc::uint32_t`: Use u32 instead.:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs#L102
warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead.
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xattr-0.2.3/src/sys/linux_macos/macos.rs:102:23
|
102 | position: uint32_t,
| ^^^^^^^^
|
variable does not need to be mutable:
Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap-4.0.26/src/builder/command.rs#L4035
warning: variable does not need to be mutable
--> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap-4.0.26/src/builder/command.rs:4035:17
|
4035 | for mut sc in &mut self.subcommands {
| ----^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|