Add Support for Inline Japanese Input in Firenvim #1643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will fix #1642
I utilized the existing
KeyHandler
. I made the background of theKeyHandler
transparent and displayed it in front of the canvas to show the Japanese text being input. Normally, the display moves along with the mouse cursor, but I modified it to appear at the cursor position only while typing.Since I haven’t fully explored the entire Firenvim implementation, there is a possibility that my changes might unintentionally break some existing functionality.
Before changes:
https://github.com/user-attachments/assets/fe63ff90-61ca-461f-af8d-33576dcefb2e
After changes:
https://github.com/user-attachments/assets/0c6a7277-e6f3-4183-90ba-97772b7df27e