Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sklearn.externals.six with six #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pasusarla
Copy link

@pasusarla pasusarla commented Feb 13, 2023

After the recent move from sklearn to scikit-learn (via PR #65), it became necessary to import six directly.

@gkhayes @ChristopherBilg May I request you to please consider?

…ctly after setting it up as a project dependency
@pasusarla
Copy link
Author

Just realized this duplicates #50 and #64. However, keeping it open seeing as those haven't been closed yet.

Copy link
Contributor

@ChristopherBilg ChristopherBilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works with my current projects. 👍

@pasusarla pasusarla closed this Feb 20, 2023
@pasusarla pasusarla reopened this Feb 20, 2023
@ChristopherBilg
Copy link
Contributor

@pasusarla Please do not close and reopen pull requests to ping people.

@pasusarla
Copy link
Author

@ChristopherBilg my apologies! It was an unfortunate stray click. I'll be careful. Thanks for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants