Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new prop and prevent default initialize #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Marcoo09
Copy link

@Marcoo09 Marcoo09 commented Oct 7, 2021

In this pull request was:

  • Added a value prop to define a default value in case it's necessary
  • Fixed a problem from my point of view in which the updater was called each time the Slider is re-rendered.

@Marcoo09
Copy link
Author

Marcoo09 commented Oct 7, 2021

Related issue #114

@Marvedog
Copy link

What's the hold up? This seems like a pretty done deal

@Marcoo09
Copy link
Author

What do you mean?
My first point it's an improvement to have the ability of define a default value in the slider, for example you use the slider in edit mode and create mode, so the first time you want to render on 0 and the second time in the last value set.
My second point it's a bug related the updater is called on the first render without touch anything.

Copy link

@windcloudit windcloudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it is ok on my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants