Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.11.0 #3130

Merged
merged 3 commits into from
Dec 13, 2023
Merged

v1.11.0 #3130

merged 3 commits into from
Dec 13, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Dec 13, 2023 •
edited
Loading

This also includes an upgrade to @vscode/test-electron to ensure that tests on Windows can run and we can be confident in these builds.

Successful CLI tests run: https://github.com/github/vscode-codeql/actions/runs/7193094410

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10
v1.11.0
15cc559
@koesie10
Upgrade @vscode/test-electron
fb713f7 
This upgrades this package to fix tests on Windows. It seems like the
extraction of the VS Code archive is failing, which is fixed in the
newest version.
@koesie10 koesie10 marked this pull request as ready for review December 13, 2023 09:36
@koesie10 koesie10 requested a review from a team as a code owner December 13, 2023 09:36
charisk
charisk approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests.

In the future, I'd personally prefer a separate PR for the test fix but appreciate that adds waiting time.

@koesie10 koesie10 requested a review from charisk December 13, 2023 11:43
@koesie10 koesie10 merged commit 0d38073 into main Dec 13, 2023
14 of 15 checks passed
@koesie10 koesie10 deleted the v1.11.0 branch December 13, 2023 13:15
@koesie10 koesie10 temporarily deployed to publish-vscode-marketplace December 13, 2023 13:17 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @charisk