Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate serialized data in build script #24

Merged
merged 11 commits into from
Oct 4, 2024

Conversation

hendrikvanantwerpen
Copy link
Contributor

@hendrikvanantwerpen hendrikvanantwerpen commented Oct 4, 2024

Instead of including the serialized data in the crate, @aneubeck suggested that we generate it at build time.

This PR introduces a new bpe-openai crate that generates serialized data as part of its build. This cannot be part of bpe directly, because that would require bpe to be available when bpe is built. The bpe-openai crate exposed public functions to get static BPE instances loaded from the serialized data generated at build time. As a convenience, it re-exports the bpe crate, so depending on this crate is enough to be able to use these tokenizers fully.

Serializing the data is a hit on compile time. But I think this shouldn't happen too often with the rerun-if-change:build.rs directive.

@hendrikvanantwerpen hendrikvanantwerpen self-assigned this Oct 4, 2024
Copy link
Collaborator

@aneubeck aneubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

crates/bpe-openai/README.md Outdated Show resolved Hide resolved
Co-authored-by: Timothy Clem <[email protected]>
@hendrikvanantwerpen hendrikvanantwerpen merged commit 61d4fd2 into initial-release Oct 4, 2024
2 checks passed
@hendrikvanantwerpen hendrikvanantwerpen deleted the generate-bpe-data branch October 4, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants