Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository visibility changes to be relevant for GHES location #35282

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Nov 14, 2024

Why:

Visibility changes should no longer refer to dotcom in GHES case.

Closes #35262

What's being changed (if available, include any code snippets, screenshots, or gifs):

{% data variables.product.prodname_dotcom_the_website %}
to
{% data variables.location.product_location %}

effectively keeping the current wording for fpt/ghec:

Changing from internal to public

  • The code will be visible to everyone who can visit GitHub.com.

and making the output for ghes read:

Changing from private to public

  • The code will be visible to everyone who can visit your GitHub Enterprise Server instance.

https://docs-35282-f0afae.preview.ghdocs.com/en/enterprise-cloud@latest/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/setting-repository-visibility#changing-from-internal-to-public
vs.
https://docs-35282-f0afae.preview.ghdocs.com/en/[email protected]/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/setting-repository-visibility#changing-from-private-to-public

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/setting-repository-visibility.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise and removed triage Do not begin working on this issue until triaged by the team labels Nov 14, 2024
@nguyenalex836
Copy link
Contributor

Howdy @janbrasna! 👋 I'm going to wait a few days to see if @sparrowt wants to open a PR with this update, as they first discovered this issue.

If they haven't submitted a PR by early next week, we can get this merged 💛

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into github:main with commit 142138c Nov 18, 2024
45 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@janbrasna janbrasna deleted the fix/ghes-visibility-location branch November 18, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository visibility docs for GHES are misleading with references to GitHub.com
2 participants