Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there are three issues causing the tests to fail when running them via bazel (one can also be provoked locally).
File.Delete(path)
a directory not found exception can be thrown (this can happen for the "long" path in case the directory has not been created). This can also happen locally, if tests are not executed in the "right order" (som tests explicitly creates the folder containing the "long" path file).In this PR we use the
TEST_TMPDIR
environment variable (when set) as the root folder for creating files and folders when running the tests. Furthermore, each test now uses a "unique" (random GUID) for long- and short filenames to avoid collisions when running in parallel and the constructor now initially creates the long path directory before we start running any tests (and some of the tests are adjusted accordingly).