-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++: Fix more FPs with extraction errors on cpp/wrong-type-format-arguments #18200
Conversation
Alert comparison looks healthy. |
Would you mind re-running DCA, as the introduction of |
I'm not sure what custom suite you used to run DCA, but please run with the nighlty one, because we also want to understand, e.g., the caching effects when running the modified query as part of the whole suite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, just one fix for the change note.
Co-authored-by: Jeroen Ketema <[email protected]>
Are you ok with the DCA build failure on lubomyr__bochs? It looks unrelated. |
Yes. It's a tracer injection failure. We have an open issue for it somewhere. |
Pull Request checklist
All query authors
.qhelp
. See the documentation in this repository.Internal query authors only
.ql
,.qll
, or.qhelp
files. See the documentation (internal access required).