Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Fix more FPs with extraction errors on cpp/wrong-type-format-arguments #18200

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

calumgrant
Copy link
Contributor

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions bot added the C++ label Dec 4, 2024
@calumgrant
Copy link
Contributor Author

Alert comparison looks healthy.

@calumgrant calumgrant marked this pull request as ready for review December 5, 2024 15:42
@calumgrant calumgrant requested a review from a team as a code owner December 5, 2024 15:42
@jketema
Copy link
Contributor

jketema commented Dec 6, 2024

Would you mind re-running DCA, as the introduction of stripType is a rather fundamental change?

@jketema
Copy link
Contributor

jketema commented Dec 6, 2024

I'm not sure what custom suite you used to run DCA, but please run with the nighlty one, because we also want to understand, e.g., the caching effects when running the modified query as part of the whole suite.

Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, just one fix for the change note.

@calumgrant
Copy link
Contributor Author

Are you ok with the DCA build failure on lubomyr__bochs? It looks unrelated.

@jketema
Copy link
Contributor

jketema commented Dec 6, 2024

Are you ok with the DCA build failure on lubomyr__bochs? It looks unrelated.

Yes. It's a tracer injection failure. We have an open issue for it somewhere.

@calumgrant calumgrant merged commit fa123a7 into main Dec 6, 2024
15 checks passed
@calumgrant calumgrant deleted the calumgrant/bmn/wrong-type-format-args2 branch December 6, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants