Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Use canonical paths for variants in data flow #18177

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Dec 2, 2024

Follow-up to #18083 and #18078.

@github-actions github-actions bot added C# Java Ruby Rust Pull requests that update Rust code DataFlow Library labels Dec 2, 2024

fn sink(s: i64) {
println!("{}", s);
}

Check notice

Code scanning / CodeQL

Unused variable Note test

Variable 's' is not used.
// has a flow model
fn identity(i: i64) -> i64 {
0
}

Check notice

Code scanning / CodeQL

Unused variable Note test

Variable 'i' is not used.
// has a flow model
fn get_var_pos(e: MyPosEnum) -> i64 {
0
}

Check notice

Code scanning / CodeQL

Unused variable Note test

Variable 'e' is not used.
// has a flow model
fn set_var_pos(i: i64) -> MyPosEnum {
MyPosEnum::A(0)
}

Check notice

Code scanning / CodeQL

Unused variable Note test

Variable 'i' is not used.
// has a flow model
fn get_var_field(e: MyFieldEnum) -> i64 {
0
}

Check notice

Code scanning / CodeQL

Unused variable Note test

Variable 'e' is not used.
// has a flow model
fn set_var_field(i: i64) -> MyFieldEnum {
MyFieldEnum::C { field_c: 0 }
}

Check notice

Code scanning / CodeQL

Unused variable Note test

Variable 'i' is not used.
result.asLibraryCallable() = this.getSummarizedCallable()
}

override EmptyLocation getLocation() { any() }

Check warning

Code scanning / CodeQL

Override with unmentioned parameter Warning

Override predicate doesn't mention
result
. Maybe mention it in a 'exists(result)'?
@hvitved hvitved force-pushed the rust/dataflow-variant-canonical-path branch from 0ebb933 to 2a68e19 Compare December 2, 2024 10:42
@hvitved hvitved force-pushed the rust/dataflow-variant-canonical-path branch from 2a68e19 to 3c767b0 Compare December 3, 2024 09:29
@hvitved hvitved marked this pull request as ready for review December 3, 2024 10:01
@paldepind paldepind self-assigned this Dec 3, 2024
@hvitved hvitved merged commit 06b1d8e into github:main Dec 3, 2024
15 checks passed
@hvitved hvitved deleted the rust/dataflow-variant-canonical-path branch December 3, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants