Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: add some performance diagnostics #18116

Merged
merged 13 commits into from
Dec 4, 2024
Merged

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Nov 26, 2024

This outputs some duration counts for various parts of the extraction process in the database in the form of a per-file breakdown in the QL DB and a summary as telemetry diagnostics.

This also adds the ability to use "external" elements in codegen (in this case File).

This outputs some duration counts for various parts of the extraction
process in the database in the form of telemetry diagnostics.

The diagnostics format was preferred to putting things in the relational
database as that will scale better to code scanning and is more flexible
as for the data we can put into it without passing through the dbscheme.
Also, although it's not the case yet, it will be possible to output
diagnostics even if creation of the database fails.
@redsun82 redsun82 requested a review from a team as a code owner November 26, 2024 15:37
@github-actions github-actions bot added the Rust Pull requests that update Rust code label Nov 26, 2024
@redsun82 redsun82 marked this pull request as draft November 29, 2024 09:55
@redsun82 redsun82 marked this pull request as ready for review November 29, 2024 15:01
@redsun82 redsun82 requested a review from a team as a code owner December 2, 2024 14:16
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@redsun82 redsun82 merged commit 80d466f into main Dec 4, 2024
32 checks passed
@redsun82 redsun82 deleted the redsun82/rust-perf-measures branch December 4, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants