C#: Use dedicated lock type where applicable. #18090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/locks
branch
5 times, most recently
from
b054e7c to
33d3218
Compare
michaelnebel
force-pushed
the
csharp/locks
branch
from
33d3218 to
6a8b115
Compare
michaelnebel
force-pushed
the
csharp/locks
branch
from
6a8b115 to
38e3913
Compare
michaelnebel
added
the
no-change-note-required
|
DCA looks good |
hvitved
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of C# 13 there is a dedicated lock object type for threat synchronization: https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-13#new-lock-object
This should perform slightly better than just locking on another object type.
In this PR we use the new
Locktype for sync locks where applicable.