Swift: Update models for better Swift 6 compatibility. #17891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Nothing to see on the DCA run, apart from analysis time slowdown / wobble. |
I'd say we can do a general change note once we're ready 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update models for better Swift 6 compatibility.
This was aimed and fixing some of the test regressions on the Swift 6 PR. I've also tried to fix other cases I found where things we model have changed in Swift 6 (or were simply missing) but it's very likely there are other library changes I have missed.
I haven't removed any older models, since (1) I'm not sure if those models still have value for various reasons and (2) even if they don't, it would require somewhat more verification work to be confident.
@redsun82 let me know if you'd like a change note for these changes specifically. Or will there be a general change note for Swift 6 changes that covers it?
I'll fire off a DCA run as well, though I'm not sure what I expect from it. Also wait to see if CI shows any further tests impacted.