KE2: implement basic usage of properties, variables and flexible types #17884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
reviewed
Nov 7, 2024
| args | ||
| ) | ||
| } | ||
| else -> { |
There was a problem hiding this comment.
What are the types that we're handling here? Do we need to add any special handling for enum entries; java/kotlin field access?
There was a problem hiding this comment.
Not explored yet; noted a TODO.
| when (val resolvedCall = ref.resolveCallTarget()) { | ||
| is KaSimpleVariableAccessCall -> { | ||
| when (val varSymbol = resolvedCall.symbol) { | ||
| is KaPropertySymbol -> { |
There was a problem hiding this comment.
Should we make this explicit that we're handling Kotlin properties here? Does the below work for synthetic java properties?
There was a problem hiding this comment.
Added a comment clarifying that the path seems to work for both
smowton
force-pushed
the
ke2/properties-and-variables
branch
from
317fdfc to
f12818a
Compare
|
@tamasvajk comments applied; will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation of property and variable accesses, and flexible types since they were needed in passing.
Choices for comment:
String!is extracted asString; the upper bound would mean we getString?instead; I don't know from memory if we get flexible types that are more complex than just flexible nullability