Add the Actions extractor to the build #17867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
LGTM!
I had forgotten I had to define two codeql_packs for Rust 😅
FYI: that is needed in order to both have a dev-friendly non-experimental target/intree/codeql-actions and the "official" experimental thing in target/intree/codeql and eventually the released CLI.
Feel free to ping me for any upcoming change or request for information!
Glad you had to figure it out first 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new Actions extractor to the CLI build. Most of the Bazel code has been lifted from the Rust extractor, which was just added a couple weeks ago. Like Rust, the Actions extractor will wind up in the
experimentaldirectory of the CLI build for now.I'll open the internal CLI PR one these changes are merged and the submodule is bumped.