Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: fix qltest on macOS, and add CI cross-platform testing of it #17841

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Rust: fix qltest on macOS, and add CI cross-platform testing of it #17841

merged 2 commits into from
Oct 25, 2024

Conversation

redsun82
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Oct 25, 2024
@redsun82 redsun82 force-pushed the redsun82/rust-fix-qltest-macos branch from f47b81f to 4e8b6dc Compare October 25, 2024 10:19
hvitved
hvitved previously approved these changes Oct 25, 2024
View reviewed changes
@redsun82 redsun82 requested a review from hvitved October 25, 2024 10:34
@redsun82
Copy link
Contributor Author

Unfortunately it turns out the part where --show-extractor-output shows the full log on failure on stdout doesn't currently work on qltest.cmd on windows. I've skipped testing that for now, and leave that up for a fix for an issue

@redsun82 redsun82 merged commit 45e9c2f into main Oct 25, 2024
13 checks passed
@redsun82 redsun82 deleted the redsun82/rust-fix-qltest-macos branch October 25, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redsun82 @hvitved