Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Add manual models for mapToObj. #17824

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Java: Add manual models for mapToObj. #17824

merged 2 commits into from
Oct 23, 2024

Conversation

michaelnebel
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Java label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,10,4618,259,99,,9,,,26
+    Java Standard Library,``java.*``,10,4621,259,99,,9,,,26
-    Totals,,312,26325,2635,404,16,128,33,1,409
+    Totals,,312,26328,2635,404,16,128,33,1,409
  • Changes to framework-coverage-java.csv:
- java.util,48,2,1336,,,,,,,,,1,,,,,,,,,,,34,,,,3,,,,5,2,,1,2,,,,,,,,,,,,,2,,,558,778
+ java.util,48,2,1339,,,,,,,,,1,,,,,,,,,,,34,,,,3,,,,5,2,,1,2,,,,,,,,,,,,,2,,,558,781

@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Oct 23, 2024
@michaelnebel michaelnebel marked this pull request as ready for review October 23, 2024 11:06
@michaelnebel michaelnebel requested a review from a team as a code owner October 23, 2024 11:06
aschackmull
aschackmull approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelnebel
Copy link
Contributor Author

DCA looks good.

@michaelnebel michaelnebel merged commit 779ee25 into github:main Oct 23, 2024
16 checks passed
@michaelnebel michaelnebel deleted the java/maptoobj branch October 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees
No one assigned
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelnebel @aschackmull