Rust: Various fixes to the CFG construction #17800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the math was wrong and the first argument (with `i` being `0`) had two edges out of it.
|
According to the DCA results this PR seems to fix the vast majority of CFG inconsistencies. There's a few still left in some projects. I'll take a look at those as well and update the PR. |
hvitved
requested changes
Oct 21, 2024
| @@ -612,6 +612,8 @@ module PatternTrees { | |||
| result = rank[i + 1](Pat pat, int j | pat = this.getPat(j) | pat order by j) | |||
| } | |||
|
|
|||
| predicate isEmpty() { not any(Pat p) = this.getPat(0) } | |||
There was a problem hiding this comment.
not exists(this.getPat(_)).
There was a problem hiding this comment.
True. I realized that that was a bug, fixed in a later commit and after 6568eb8 it got removed as the behavior is now inherited from StandardTree.
|
I've updated the PR to fix the CI and add one more inconsistency fix ( |
hvitved
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of inconsistencies in the CFG construction. This should reduce the number of CFG inconsistencies we see on real projects quite a bit.
Most of these are simple fixes and come with test cases and separate commits, so I won't describe them in detail. Please ask or comment if there's anything that's not clear.