Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add Tainted Path sanitizers #17759

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Go: Add Tainted Path sanitizers #17759

wants to merge 7 commits into from

Conversation

Kwstubbs
Copy link
Contributor

@Kwstubbs Kwstubbs commented Oct 15, 2024 •
edited
Loading

Add gorilla mux.Vars sanitizer

@Kwstubbs Kwstubbs requested a review from a team as a code owner October 15, 2024 02:52
owen-mc
owen-mc reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for net/url.URL.Path, and mention it in the change note. Also, why do you think that reading that field is a sanitizer? I don't see anything in the docs about what characters it may or may not contain.

go/ql/lib/semmle/go/security/TaintedPathCustomizations.qll Outdated Show resolved Hide resolved
go/ql/lib/semmle/go/security/TaintedPathCustomizations.qll Outdated Show resolved Hide resolved
go/ql/test/query-tests/Security/CWE-022/TaintedPath.go Outdated Show resolved Hide resolved
go/ql/lib/semmle/go/security/TaintedPathCustomizations.qll Outdated Show resolved Hide resolved
go/ql/lib/semmle/go/security/TaintedPathCustomizations.qll Outdated Show resolved Hide resolved
go/ql/lib/semmle/go/security/TaintedPathCustomizations.qll Outdated Show resolved Hide resolved
@Kwstubbs
Copy link
Contributor Author

Kwstubbs commented Oct 15, 2024 •
edited
Loading

@owen-mc It seems the default mux also sanitizes the path using this function. It seems there are also some changes implemented in version 1.22 from the comments here that I have yet to test (I'm on 1.21). I'll go ahead and remove the net/url.URL.Path sanitizer for now and possibly come back to it.

@Kwstubbs Kwstubbs requested a review from owen-mc October 15, 2024 21:34
owen-mc
owen-mc reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just need to add two tests for SkipClean (called with true and false).

go/ql/test/query-tests/Security/CWE-022/vendor/github.com/gorilla/mux/LICENSE Outdated Show resolved Hide resolved
go/ql/lib/semmle/go/security/TaintedPathCustomizations.qll Outdated Show resolved Hide resolved
@Kwstubbs Kwstubbs requested a review from owen-mc November 13, 2024 00:21
owen-mc
owen-mc previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only very minor comments left.

go/ql/src/change-notes/2024-10-14-gopathsanitizer.md Outdated Show resolved Hide resolved
go/ql/test/query-tests/Security/CWE-022/GorillaMuxDefault/MuxClean.go Outdated Show resolved Hide resolved
go/ql/test/query-tests/Security/CWE-022/GorillaMuxSkipClean/MuxClean.go Outdated Show resolved Hide resolved
@owen-mc
Copy link
Contributor

owen-mc commented Nov 13, 2024 •
edited
Loading

I think if you're just committing my suggestions it doesn't dismiss my review.

@Kwstubbs @owen-mc
Apply suggestions from code review
a94ba25 
Co-authored-by: Owen Mansel-Chan <[email protected]>
@Kwstubbs
Copy link
Contributor Author

committing suggestions didn't work 😞

@Kwstubbs Kwstubbs requested a review from owen-mc November 13, 2024 22:48
@owen-mc
Copy link
Contributor

owen-mc commented Nov 13, 2024

committing suggestions didn't work 😞

Shows how much I know 😆 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-mc owen-mc owen-mc approved these changes

Assignees
No one assigned
Labels
documentation Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kwstubbs @owen-mc