Rust: Remove the workaround in rust/unused-variable.

[geoffw0]

Remove the workaround in rust/unused-variable that restricts results to files called main.rs (because we were getting far too many results otherwise).

Once the necessary fixes are in, we can check a DCA run succeeds [sufficiently cleanly] with this change, merge it, and the query is finished!

[aibaars]

This has a conflict now. It would be nice to run an experiment to see if we can remove the restriction.

[geoffw0]

This has a conflict now.

Fixed (force push, it's a single line change but has moved from one file to another).

It would be nice to run an experiment to see if we can remove the restriction.

100% agree (especially since #17865 has been merged). I've just started a run...

[geoffw0]

The DCA run shows 282,889 new results for rust/unused-variable. The run itself didn't fail, but this is obviously far too many to be considered reasonable.

[aibaars]

The DCA run shows 282,889 new results for rust/unused-variable. The run itself didn't fail, but this is obviously far too many to be considered reasonable.

Yes, that is still quite high. However, since it doesn't cause a problem for the DCA tests, I think we could merge this PR. That way we have a baseline on which we can improve things.

[geoffw0]

OK, I'll fix the CI failure then...

[geoffw0]

It looks like one test was affected, and it's an improvement. Specifically, the workaround removed here (removing results from rust/unused-variable outside of main.rs) had an unintended interaction with the logic in rust/unused-value excluding results that are overlaps between the two queries. I'm glad to be rid of this.