Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: Upgrade to 8.0.0rc1 #17732

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Bazel: Upgrade to 8.0.0rc1 #17732

merged 1 commit into from
Oct 28, 2024

Conversation

criemen
Copy link
Collaborator

@criemen criemen commented Oct 10, 2024

No description provided.

@criemen criemen changed the title Bazel: Upgrade to bazel 8.0.0rc1 Bazel: Upgrade to 8.0.0rc1 Oct 10, 2024
@criemen criemen force-pushed the criemen/bazel-8 branch 4 times, most recently from 8a02e62 to 9049785 Compare October 15, 2024 14:38
@github-actions github-actions bot added the Go label Oct 15, 2024
@criemen criemen force-pushed the criemen/bazel-8 branch 9 times, most recently from 5d44fec to 342ab3d Compare October 22, 2024 09:07
@github-actions github-actions bot removed the Go label Oct 24, 2024
@criemen criemen marked this pull request as ready for review October 24, 2024 14:07
@criemen criemen requested a review from a team as a code owner October 24, 2024 14:07
@@ -1,5 +1,4 @@
common --enable_platform_specific_config
common --enable_bzlmod
# because we use --override_module with `%workspace%`, the lock file is not stable
common --lockfile_mode=off
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really related, but I remember discussing turning the lock file on and adding it to .gitignore to at least locally have the advantages of the lock file...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the internal repo that's what we're doing - let's do that separately from this PR.

@criemen criemen merged commit 1972532 into main Oct 28, 2024
21 checks passed
@criemen criemen deleted the criemen/bazel-8 branch October 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants