Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Restrict variables to lowercase (for now). #17718

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Oct 9, 2024

Temporary workaround for misrecognising enum constants as variable names. This is not always accurate (see the comment) but should lean towards too few things being recognised as variables rather than too many, which is better for the quality of results.

@hvitved

@geoffw0 geoffw0 added the Rust Pull requests that update Rust code label Oct 9, 2024
hvitved
hvitved previously approved these changes Oct 9, 2024
@geoffw0
Copy link
Contributor Author

geoffw0 commented Oct 9, 2024

There was a test failure in one of the library tests (also a match case of None).

@geoffw0 geoffw0 merged commit 25b3d76 into github:main Oct 10, 2024
14 checks passed
@geoffw0 geoffw0 deleted the unusedvar4 branch October 29, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants