Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Add taint through fopen #17715

Merged
merged 5 commits into from
Oct 10, 2024
Merged

C++: Add taint through fopen #17715

merged 5 commits into from
Oct 10, 2024

Conversation

MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Oct 9, 2024

Pull Request checklist

Ideally this should've been done through MaD, but considering that we had the Fopen class already I couldn't really be bothered to convert it to MaD 😂

I'll run DCA once that's unbroken.

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

geoffw0
geoffw0 previously approved these changes Oct 9, 2024
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MathiasVP
Copy link
Contributor Author

One new result (I had expected more really 😭), but a least it looks like a TP. Merging!

@MathiasVP MathiasVP merged commit e7da53d into github:main Oct 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants