Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: model that re.finditer returns an iterable of re.Match objects #17712

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

yoff
Copy link
Contributor

@yoff yoff commented Oct 9, 2024

Do we want a change note for this?

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@yoff yoff requested a review from a team as a code owner October 9, 2024 10:46
@github-actions github-actions bot added the Python label Oct 9, 2024
@sidshank
Copy link
Contributor

sidshank commented Oct 9, 2024

Do we want a change note for this?

If it has the potential to surface new alerts, that's a user-visible change that I think should be accompanied by a change note. 🙏🏼

Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, otherwise this looks good to me! 👍

---
category: minorAnalysis
---
* Modelled that `re.finditer` returns an iterable of `re.Match` objects. This is now understood by the API graph in many cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Modelled that `re.finditer` returns an iterable of `re.Match` objects. This is now understood by the API graph in many cases.
* Modeled that `re.finditer` returns an iterable of `re.Match` objects. This is now understood by the API graph in many cases.

We should stick to the US spelling, alas.

@yoff yoff merged commit 2af60f1 into github:main Oct 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants