Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Add a skeleton class for requires expressions #17693

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Oct 8, 2024

Postponing adding a change note until this is more complete.

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema jketema added the no-change-note-required This PR does not need a change note label Oct 9, 2024
@jketema jketema marked this pull request as ready for review October 9, 2024 06:07
@jketema jketema requested a review from a team as a code owner October 9, 2024 06:07
@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Oct 9, 2024
Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@jketema jketema merged commit 8352d17 into github:main Oct 9, 2024
14 of 15 checks passed
@jketema jketema deleted the concepts branch October 9, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants