Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#/Java: Avoid df and dfc overlap in model generation. #17687

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Oct 8, 2024

It turns out that we in some cases still produce mixed models that both have df and dfc provenance. In this PR we further reduce this overlap.

@github-actions github-actions bot added the C# label Oct 8, 2024
@michaelnebel michaelnebel marked this pull request as ready for review October 8, 2024 13:38
@michaelnebel michaelnebel requested a review from a team as a code owner October 8, 2024 13:38
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Oct 8, 2024
@michaelnebel michaelnebel requested a review from hvitved October 8, 2024 13:39
@michaelnebel michaelnebel force-pushed the modelgen/removeduplicatedf branch from a451dfc to 5bdf24e Compare October 9, 2024 07:46
hvitved
hvitved previously approved these changes Oct 9, 2024
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me.

@michaelnebel michaelnebel merged commit 79871aa into github:main Oct 9, 2024
37 of 38 checks passed
@michaelnebel michaelnebel deleted the modelgen/removeduplicatedf branch October 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants