SSA: Add BarrierGuardWithState #17661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
previously approved these changes
Oct 7, 2024
shared/ssa/codeql/ssa/Ssa.qll
Outdated
| bindingset[this] | ||
| signature class StateSig; | ||
|
|
||
| module WithState<StateSig State> { |
hvitved
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
BarrierGuardWithState<>for when you need a barrier guard where the flow state is part of the signature.In most cases one could get by with just implementing separate barrier guards for each flow state, but in JS we need this in order to share barrier guards between the shared library and old data flow library.