Shared ConditionalCompletionSplitting implementation
#17658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
shared/cfg-conditional-splitting
branch
from
616fd3e to
2e8bfea
Compare
hvitved
force-pushed
the
shared/cfg-conditional-splitting
branch
from
2e8bfea to
1a9a6bc
Compare
hvitved
force-pushed
the
shared/cfg-conditional-splitting
branch
2 times, most recently
from
f73ce49 to
c2e202f
Compare
hvitved
force-pushed
the
shared/cfg-conditional-splitting
branch
from
c2e202f to
bdb793b
Compare
MathiasVP
approved these changes
Oct 9, 2024
|
DCA looks good, so merging. |
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, I would have liked for
SplitImplementations::ConditionalCompletionSplittingto be parameterized overConditionalCompletionSplittingInputinstead of having the outerMakeWithSplittingbe parameterized over it, but then it would not be possible to extend the abstractSplitImplclass.