Rust: &(mut) x is neither a read nor a write
#17655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/variable-mut
branch
from
40b82f7 to
e7f09e6
Compare
hvitved
force-pushed
the
rust/variable-mut
branch
from
e7f09e6 to
a9cf33c
Compare
hvitved
changed the title
&mut x references to be writes&(mut) x is neither a read nor a write
geoffw0
reviewed
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking the address of a variable
xvia&(mut) xneither reads nor writes the variable, so the access toxshould neither be aVariableReadAccessnor aVariableWriteAccess. This also includes implicit references in compound assignmentsx += ywhich really means(&mut x).add_assign(y).Note that once we implement SSA support, then (some) variable references will be modeled as uncertain variable writes.