Rust: More information about extractor errors and warnings #17647
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@aibaars sync-identical-files is failing, it wants me to update the Ruby version of |
The purpose of the sync check is to avoid having diverging implementations between languages. I think we should strive for consistency across languages. It's really annoying if all the diagnostics libraries have very similar but slightly differing behaviour. I think your changes to Diagnostics.qll are fine, and could be applied to Ruby as well. Just make sure that behaviour doesn't change and add a change note if needed. |
…nings, and mostly restore original behaviour.
…ything we had before.
|
I've done the same changes for Ruby. Definitely deserves a review from the Ruby perspective (and I wouldn't be surprised if some consistency tests need updating when CI has run them all). |
| from ExtractionWarning warning, File f | ||
| where | ||
| f = warning.getLocation().getFile() and | ||
| exists(f.getRelativePath()) | ||
| select warning, "Extraction warning in " + f + " with message " + warning.getMessage(), | ||
| getSeverity() |
Check warning
Code scanning / CodeQL
Consistent alert message Warning
|
@github/codeql-ruby please take a look at the Ruby changes here (that mirror changes made in Rust). Thanks. |
Co-authored-by: Arthur Baars <[email protected]>
|
Both Rust and Ruby changes have been approved (admittedly by the same person), CI is happy. Merging. |
Output more information about extractor errors and warnings:
rust/diagnostics/extraction-warningslisting extractor warnings.rust/diagnostics/extraction-errorsto output only errors, not errors and warnings.Diagnosticthat is not an warning. However that may change, and doing all this right ensures that code and DCA output are not confusing.rust/summary/summary-statistics. This is helpful for examining databases manually.SuccessfullyExtractedFileto improve code re-use.