Bazel: stub internal repo parts needed for building rust binaries #17387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another shot at #17382, using a different and more lightweight approach. This allows building the ruby and python (and in the future also rust) packs from within the codeql repository. This will: * skip defining the glibc symbols checking, which only makes sense when building the release from the internal repository * stub out our `universal_binary` rule, which we only need when building the release.
criemen
approved these changes
Sep 5, 2024
| @@ -8,7 +8,7 @@ def codeql_rust_binary( | |||
| visibility = None, | |||
| symbols_test = True, | |||
| **kwargs): | |||
| rust_label_name = name + "_single_arch" | |||
| rust_label_name = "single_arch/" + name | |||
There was a problem hiding this comment.
(mind that this is not just stylistic, by stubbing universal_binary with an alias this was required to preserve the base name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another shot at #17382, using a different and more lightweight approach.
This allows building the ruby and python (and in the future also rust) packs from within the codeql repository. This will:
universal_binaryrule, which we only need when building the release.