Go 1.23 fixups #17341
Open
Go 1.23 fixups #17341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
force-pushed
the
smowton/admin/go1.23-wip
branch
from
6074085 to
f18a83a
Compare
Previously we had structs with different trap labels (because the labels already included the tags, which make structs non-identical), but no way to distinguish them in QL.
…on extracting an alias
…exported methods defined in different packages
…eType deep-unalias bug
smowton
force-pushed
the
smowton/admin/go1.23-wip
branch
from
f18a83a to
0d3a0d9
Compare
This means that there is a target for defs and refs to refer to after the original fields go away because their corresponding structs have also gone away on a database downgrade.
|
Positive DCA results: https://github.com/github/codeql-dca-main/issues/23447 Now running QA: https://github.com/github/codeql-qa-ops/issues/191 |
…if they are variadic)
|
Did you see that https://github.com/bazelbuild/rules_go/releases/tag/v0.50.0 was released? That way, we should be able to fully rely on upstream again. |
|
Thanks, commented there instead! |
|
For future reference: DCA results were good, but with the addition of the stats commit they are terrible. A stats update really ought to happen due to adding a new table, but evidently it has caused a bad join order somewhere important. This will also apply to smaller PRs that are adding tables |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.