Java: Port all integration tests to pytest #17315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also used by the integration tests.
Some notes: * These tests rely on a variety of fixtures * The previous maven-wrapper checks were checking for the version of maven installed by looking at the checked-in wrapper script. I dropped this behavior. * I replaced a lot of test queries that queried for a (subset of) source archive files with the source_archive fixture. In particular, tests that excluded properties files from being listed in the expected output now include them. It's much faster to generate this list via the fixture instead of using CodeQL for it.
criemen
added
the
depends on internal PR
redsun82
previously approved these changes
Aug 29, 2024
Comment on lines
5
to
21
| commands.run(["javac", "mod1/module-info.java", "mod1/mod1pkg/Mod1Class.java", "-d", "mod1obj"]) | ||
| commands.run( | ||
| [ | ||
| "jar", | ||
| "-c", | ||
| "-f", | ||
| "mod1.jar", | ||
| "-C", | ||
| "mod1obj", | ||
| "mod1pkg/Mod1Class.class", | ||
| "--release", | ||
| "9", | ||
| "-C", | ||
| "mod1obj", | ||
| "module-info.class", | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Stylistic nit, you can use strings instead of lists of strings, and combine the two calls:
Suggested change
| commands.run(["javac", "mod1/module-info.java", "mod1/mod1pkg/Mod1Class.java", "-d", "mod1obj"]) | |
| commands.run( | |
| [ | |
| "jar", | |
| "-c", | |
| "-f", | |
| "mod1.jar", | |
| "-C", | |
| "mod1obj", | |
| "mod1pkg/Mod1Class.class", | |
| "--release", | |
| "9", | |
| "-C", | |
| "mod1obj", | |
| "module-info.class", | |
| ] | |
| ) | |
| commands.run( | |
| "javac mod1/module-info.java mod1/mod1pkg/Mod1Class.java -d mod1obj", | |
| "jar -c -f mod1.jar -C mod1obj mod1pkg/Mod1Class.class --release 9 -C mod1obj module-info.class", | |
| ) |
Comment on lines
5
to
21
| commands.run(["javac", "mod1/module-info.java", "mod1/mod1pkg/Mod1Class.java", "-d", "mod1obj"]) | ||
| commands.run( | ||
| [ | ||
| "jar", | ||
| "-c", | ||
| "-f", | ||
| "mod1.jar", | ||
| "-C", | ||
| "mod1obj", | ||
| "mod1pkg/Mod1Class.class", | ||
| "--release", | ||
| "9", | ||
| "-C", | ||
| "mod1obj", | ||
| "module-info.class", | ||
| ] | ||
| ) |
There was a problem hiding this comment.
as above, you can combine the commands.run calls and use one-line strings
redsun82
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
It's much faster to generate this list via the fixture instead of using a codeql query.