Fix ripunzip installation. #17302
Closed
Fix ripunzip installation. #17302
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the install script fails when being run from the main repo, inside the ripunzip fixture.
|
Hm, moving the bazel call into the submodule, and not invoking the target via superrepo fixes this, and also means we don't need to provide a sparse checkout with all the files required for bazel to run. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the install script fails when being run from the main repo, inside the ripunzip fixture.
Reproducing this error might require a custom branch of mine, and debugging this is not worth my time.
So I think we should just include the runfiles snippet here and be done with it, sorry 🤷