Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared: Fix bad join in content flow. #17301

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Aug 26, 2024

17950      ~0%     {7} r1 = JOIN `_CaptureModels::PropagateContentFlow::nodeReaches/6#a1f43490#prev_delta_DataFlowImpl::Impl<CaptureMo__#shared` WITH `CaptureModels::PropagateContentFlow::readStep/5#34c0c273#cpe#25` ON FIRST 1 OUTPUT Lhs.4, Lhs.1 'source', Lhs.2 'scReads', Lhs.3 'scStores', Lhs.5 'reads', Lhs.6 'stores', Rhs.1
17950      ~1%     {8}    | JOIN WITH `DataFlowImpl::Impl<CaptureModels::PropagateContentFlow::Flow::C>::S6::PathNode.getNode/0#dispred#c4a4b697` ON FIRST 1 OUTPUT Lhs.6, Lhs.1 'source', Lhs.2 'scReads', Lhs.3 'scStores', Lhs.0, Lhs.4 'reads', Lhs.5 'stores', Rhs.1
1149877000 ~0%     {8}    | JOIN WITH `DataFlowImpl::Impl<CaptureModels::PropagateContentFlow::Flow::C>::S6::PathNode.getState/0#dispred#06e3fe70_10#join_rhs` ON FIRST 1 OUTPUT Lhs.4, Rhs.1 'node', Lhs.1 'source', Lhs.2 'scReads', Lhs.3 'scStores', Lhs.5 'reads', Lhs.6 'stores', Lhs.7
6088       ~2%     {7}    | JOIN WITH `DataFlowImpl::Impl<CaptureModels::PropagateContentFlow::Flow::C>::S6::PathNode.getASuccessor/0#dispred#3b7dd794` ON FIRST 2 OUTPUT Lhs.1 'node', Lhs.2 'source', Lhs.3 'scReads', Lhs.4 'scStores', Lhs.5 'reads', Lhs.6 'stores', Lhs.7
6088       ~2%     {8}    | JOIN WITH `DataFlowImpl::Impl<CaptureModels::PropagateContentFlow::Flow::C>::S6::PathNode.getNode/0#dispred#c4a4b697` ON FIRST 1 OUTPUT Lhs.6, Rhs.1, Lhs.1 'source', Lhs.2 'scReads', Lhs.3 'scStores', Lhs.4 'reads', Lhs.5 'stores', Lhs.0 'node'
4704       ~0%     {7}    | JOIN WITH `CaptureModels::PropagateContentFlow::readStep/5#34c0c273#cpe#134_021#join_rhs` ON FIRST 2 OUTPUT Rhs.2 'c', Lhs.5 'reads', Lhs.2 'source', Lhs.3 'scReads', Lhs.4 'scStores', Lhs.7 'node', Lhs.6 'stores'
4704       ~0%     {7}    | AND NOT `CaptureModels::PropagateContentFlow::nodeReachesRead/7#063d6ac5#reorder_4_5_0_1_2_3_6#prev`(FIRST 7)
                                         return r1

This is a pre-requisite for further field based model generation for java.

With this performance improvement a quick and dirty field based model generation for the java sdk yielded
image

@michaelnebel michaelnebel requested a review from hvitved August 26, 2024 12:31
@michaelnebel michaelnebel marked this pull request as ready for review August 26, 2024 12:31
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Aug 26, 2024
@michaelnebel michaelnebel force-pushed the shared/contentflowbadjoin branch from 0afa13a to 77bfe39 Compare August 26, 2024 13:25
@michaelnebel michaelnebel merged commit 287857c into github:main Aug 27, 2024
29 checks passed
@michaelnebel michaelnebel deleted the shared/contentflowbadjoin branch August 27, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataFlow Library no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants