C++: Add basic modeling of functions that don't throw #17298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paldepind
commented
Aug 26, 2024
| * | ||
| * Note: The `throw` specifier was deprecated in C++11 and removed in C++17. | ||
| */ | ||
| class NoexceptFunction extends NonThrowingFunction { |
There was a problem hiding this comment.
Since the throw() signifier is deprecated & removed in the C++ standard I decided to just name this class after the noexcept signifier. This seems simpler than having the name reflect both the signifiers.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
If I'm reading the DCA results correctly this PR does not have any effect on the query results for the projects that DCA covers. |
geoffw0
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Minor comments, changes and tests otherwise LGTM.
I think we should model a few more functions with this, though as it currently only affects one query it's probably not worth spending too long on it. Perhaps printf (see Printf, Fprintf, Sprintf), strcpy (StrcpyFunction)
and strcat (StrcatFunction) would be nice to have as well.
…inor fixes to docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic modeling of functions that don't throw.
For now I've just let the classes for the two C functions mentioned in the issue,
memsetandmemcpy, extend the new class.