Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Add aggregated compiler and extractor message counts to extractio… #17287

Merged
merged 1 commit into from
Aug 23, 2024
Merged

C#: Add aggregated compiler and extractor message counts to extractio… #17287

merged 1 commit into from
Aug 23, 2024

Conversation

tamasvajk
Copy link
Contributor

…n telemetry query

@github-actions github-actions bot added the C# label Aug 22, 2024
@tamasvajk tamasvajk force-pushed the message-count-telemetry branch from d121536 to 6827bed Compare August 22, 2024 13:14
@tamasvajk
Copy link
Contributor Author

The second DCA experiment linked above was run on a subset of "buildless" repos with CODEQL_EXTRACTOR_CSHARP_OPTION_MESSAGE_LIMIT=0 and CODEQL_EXTRACTOR_CSHARP_OPTION_COMPILER_DIAGNOSTIC_LIMIT=0. And the used bundle is the head of this PR. It shows no tuple wobbles.
The first DCA experiment shows the expected increased number of cs/telemetry/extraction-information.

@tamasvajk tamasvajk marked this pull request as ready for review August 23, 2024 07:28
@tamasvajk tamasvajk requested a review from a team as a code owner August 23, 2024 07:28
@tamasvajk tamasvajk added the no-change-note-required This PR does not need a change note label Aug 23, 2024
michaelnebel
michaelnebel approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tamasvajk tamasvajk merged commit d710c1e into github:main Aug 23, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel michaelnebel approved these changes

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamasvajk @hvitved @michaelnebel