Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Resolve conflicts after merging 'main' into shared data flow branch #17285

Merged

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Aug 22, 2024

As usual, targeting js/shared-dataflow-merge-main which contains js/shared-dataflow-branch with main merged into it.

Some of the relevant changes on main that needed fixups:

  • This PR caused negative recursion on the shared data flow branch, and needed a fixup to be evaluted during the TEarlyStageNode stage.
  • Some test output has changed as a result of the recent subpaths refactoring.
  • Some minor changes to test cases result in changed updates

@asgerf asgerf added the no-change-note-required This PR does not need a change note label Aug 22, 2024
@github-actions github-actions bot added the JS label Aug 22, 2024
These files conflicted and have been regenerated.
@asgerf asgerf force-pushed the js/shared-dataflow-bump branch from 8ec2eb4 to a2dd47a Compare August 22, 2024 12:27
@asgerf asgerf marked this pull request as ready for review August 23, 2024 06:33
@asgerf asgerf requested a review from a team as a code owner August 23, 2024 06:33
@asgerf
Copy link
Contributor Author

asgerf commented Aug 23, 2024

The QLDoc check failure can be ignored, as it is caused by compilation errors on the target branch (which doesn't compile due to the merge conflicts that are resolved in this PR).

@asgerf asgerf requested a review from erik-krogh August 23, 2024 07:53
@asgerf asgerf merged commit 379952f into github:js/shared-dataflow-merge-main Aug 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants