Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Try to fix packages in frameworks coverage #17284

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Aug 22, 2024

Teach the automation that when looking at the package column of a model it should ignore fixed-version: at the beginning and strip out any major version suffix (like /v2 or .v3). Also teach it that / is the separator for package paths in go, so now it understands that os/exec should be counted under the "canonical package" of os, which is fine as we want them both lumped into the "Standard library" bucket. I think this means we can stop using so many * when listing which canonical packages go in which buckets, e.g. we can put os instead of os*.

@github-actions github-actions bot added the Go label Aug 22, 2024
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
-    `Couchbase official client(gocb) <https://github.com/couchbase/gocb>`_,"``github.com/couchbase/gocb*``, ``gopkg.in/couchbase/gocb*``",,,8
+    `Couchbase official client(gocb) <https://github.com/couchbase/gocb>`_,"``github.com/couchbase/gocb*``, ``gopkg.in/couchbase/gocb*``",,36,16
-    `Couchbase unofficial client <http://www.github.com/couchbase/go-couchbase>`_,``github.com/couchbaselabs/gocb*``,,,4
+    `Couchbase unofficial client <http://www.github.com/couchbase/go-couchbase>`_,``github.com/couchbaselabs/gocb*``,,18,8
-    Others,"``fixed-version:github.com/couchbase/gocb``, ``fixed-version:github.com/couchbaselabs/gocb``, ``fixed-version:gopkg.in/couchbase/gocb.v1``, ``github.com/Masterminds/squirrel``, ``github.com/caarlos0/env``, ``github.com/go-gorm/gorm``, ``github.com/go-xorm/xorm``, ``github.com/gobuffalo/envy``, ``github.com/gogf/gf/database/gdb``, ``github.com/hashicorp/go-envparse``, ``github.com/jinzhu/gorm``, ``github.com/jmoiron/sqlx``, ``github.com/joho/godotenv``, ``github.com/kelseyhightower/envconfig``, ``github.com/lann/squirrel``, ``github.com/raindog308/gorqlite``, ``github.com/rqlite/gorqlite``, ``github.com/uptrace/bun``, ``go.mongodb.org/mongo-driver/mongo``, ``gopkg.in/Masterminds/squirrel``, ``gorm.io/gorm``, ``xorm.io/xorm``",23,56,428
+    Others,"``github.com/Masterminds/squirrel``, ``github.com/caarlos0/env``, ``github.com/go-gorm/gorm``, ``github.com/go-xorm/xorm``, ``github.com/gobuffalo/envy``, ``github.com/gogf/gf/database/gdb``, ``github.com/hashicorp/go-envparse``, ``github.com/jinzhu/gorm``, ``github.com/jmoiron/sqlx``, ``github.com/joho/godotenv``, ``github.com/kelseyhightower/envconfig``, ``github.com/lann/squirrel``, ``github.com/raindog308/gorqlite``, ``github.com/rqlite/gorqlite``, ``github.com/uptrace/bun``, ``go.mongodb.org/mongo-driver/mongo``, ``gopkg.in/Masterminds/squirrel``, ``gorm.io/gorm``, ``xorm.io/xorm``",23,2,416
  • Changes to framework-coverage-go.csv:
- crypto,,,1,,,,,,,,,,,,,,,,,,,,1,
+ crypto,,,10,,,,,,,,,,,,,,,,,,,,10,
- crypto/cipher,,,3,,,,,,,,,,,,,,,,,,,,3,
- crypto/rsa,,,2,,,,,,,,,,,,,,,,,,,,2,
- crypto/tls,,,3,,,,,,,,,,,,,,,,,,,,3,
- crypto/x509,,,1,,,,,,,,,,,,,,,,,,,,1,
- database/sql,24,,7,,,,,,,,,,,,24,,,,,,,,7,
+ database/sql,30,,11,,,,,,,,,,,,30,,,,,,,,11,
- database/sql/driver,6,,4,,,,,,,,,,,,6,,,,,,,,4,
- encoding,,,4,,,,,,,,,,,,,,,,,,,,4,
- encoding/ascii85,,,2,,,,,,,,,,,,,,,,,,,,2,
- encoding/asn1,,,8,,,,,,,,,,,,,,,,,,,,8,
- encoding/base32,,,3,,,,,,,,,,,,,,,,,,,,3,
- encoding/base64,,,3,,,,,,,,,,,,,,,,,,,,3,
- encoding/binary,,,2,,,,,,,,,,,,,,,,,,,,2,
- encoding/csv,,,5,,,,,,,,,,,,,,,,,,,,5,
- encoding/gob,,,7,,,,,,,,,,,,,,,,,,,,7,
+ encoding,,,77,,,,,,,,,,,,,,,,,,,,77,
- encoding/hex,,,3,,,,,,,,,,,,,,,,,,,,3,
- encoding/json,,,14,,,,,,,,,,,,,,,,,,,,14,
- encoding/pem,,,3,,,,,,,,,,,,,,,,,,,,3,
- encoding/xml,,,23,,,,,,,,,,,,,,,,,,,,23,
- fixed-version:github.com/couchbase/gocb,4,,18,,,,,4,,,,,,,,,,,,,,,18,
- fixed-version:github.com/couchbaselabs/gocb,4,,18,,,,,4,,,,,,,,,,,,,,,18,
- fixed-version:gopkg.in/couchbase/gocb.v1,4,,18,,,,,4,,,,,,,,,,,,,,,18,
- github.com/astaxie/beego,16,6,7,,,,11,,4,,,,,,,1,,,,,,6,7,
+ github.com/astaxie/beego,71,21,21,,,,34,,5,,,,,,30,2,,,,,,21,21,
+ github.com/beego/beego,142,42,42,,,,68,,10,,,,,,60,4,,,,,,42,42,
- github.com/astaxie/beego/context,2,15,1,,,,,,1,,,,,,,1,,,,,,15,1,
- github.com/astaxie/beego/logs,22,,,,,,22,,,,,,,,,,,,,,,,,
- github.com/astaxie/beego/orm,30,,,,,,,,,,,,,,30,,,,,,,,,
- github.com/astaxie/beego/utils,1,,13,,,,1,,,,,,,,,,,,,,,,13,
- github.com/beego/beego,16,6,7,,,,11,,4,,,,,,,1,,,,,,6,7,
- github.com/beego/beego/client/orm,30,,,,,,,,,,,,,,30,,,,,,,,,
- github.com/beego/beego/context,2,15,1,,,,,,1,,,,,,,1,,,,,,15,1,
- github.com/beego/beego/core/logs,22,,,,,,22,,,,,,,,,,,,,,,,,
- github.com/beego/beego/core/utils,1,,13,,,,1,,,,,,,,,,,,,,,,13,
- github.com/beego/beego/logs,22,,,,,,22,,,,,,,,,,,,,,,,,
- github.com/beego/beego/orm,30,,,,,,,,,,,,,,30,,,,,,,,,
- github.com/beego/beego/server/web,16,6,7,,,,11,,4,,,,,,,1,,,,,,6,7,
- github.com/beego/beego/server/web/context,2,15,1,,,,,,1,,,,,,,1,,,,,,15,1,
- github.com/beego/beego/utils,1,,13,,,,1,,,,,,,,,,,,,,,,13,
- github.com/couchbase/gocb/v2,4,,,,,,,4,,,,,,,,,,,,,,,,
+ github.com/couchbase/gocb,8,,18,,,,,8,,,,,,,,,,,,,,,18,
- github.com/couchbaselabs/gocb/v2,4,,,,,,,4,,,,,,,,,,,,,,,,
+ github.com/couchbaselabs/gocb,8,,18,,,,,8,,,,,,,,,,,,,,,18,
- github.com/go-jose/go-jose,2,,,,2,,,,,,,,,,,,,,,,,,,
- github.com/go-jose/go-jose/jwt,1,,4,,,1,,,,,,,,,,,,,,,,,4,
+ github.com/go-jose/go-jose,3,,4,,2,1,,,,,,,,,,,,,,,,,4,
- github.com/lestrrat-go/jwx,1,,,,1,,,,,,,,,,,,,,,,,,,
+ github.com/lestrrat-go/jwx,2,,,,2,,,,,,,,,,,,,,,,,,,
- github.com/lestrrat-go/jwx/jwk,1,,,,1,,,,,,,,,,,,,,,,,,,
- github.com/square/go-jose,2,,,,2,,,,,,,,,,,,,,,,,,,
- github.com/square/go-jose/jwt,1,,4,,,1,,,,,,,,,,,,,,,,,4,
+ github.com/square/go-jose,3,,4,,2,1,,,,,,,,,,,,,,,,,4,
- gopkg.in/couchbase/gocb.v2,4,,,,,,,4,,,,,,,,,,,,,,,,
+ gopkg.in/couchbase/gocb,8,,18,,,,,8,,,,,,,,,,,,,,,18,
- gopkg.in/go-jose/go-jose,2,,,,2,,,,,,,,,,,,,,,,,,,
- gopkg.in/go-jose/go-jose/jwt,1,,4,,,1,,,,,,,,,,,,,,,,,4,
+ gopkg.in/go-jose/go-jose,3,,4,,2,1,,,,,,,,,,,,,,,,,4,
- gopkg.in/square/go-jose,2,,,,2,,,,,,,,,,,,,,,,,,,
- gopkg.in/square/go-jose/jwt,1,,4,,,1,,,,,,,,,,,,,,,,,4,
+ gopkg.in/square/go-jose,3,,4,,2,1,,,,,,,,,,,,,,,,,4,
- html,,,2,,,,,,,,,,,,,,,,,,,,2,
+ html,,,8,,,,,,,,,,,,,,,,,,,,8,
- html/template,,,6,,,,,,,,,,,,,,,,,,,,6,
- io,,,19,,,,,,,,,,,,,,,,,,,,19,
- io/fs,,3,13,,,,,,,,,,,,,,,,,,3,,13,
- io/ioutil,5,1,2,,,,,,5,,,,,,,,,,,,1,,2,
+ io,5,4,34,,,,,,5,,,,,,,,,,,,4,,34,
- mime,,,5,,,,,,,,,,,,,,,,,,,,5,
+ mime,,,14,,,,,,,,,,,,,,,,,,,,14,
- mime/multipart,,,8,,,,,,,,,,,,,,,,,,,,8,
- mime/quotedprintable,,,1,,,,,,,,,,,,,,,,,,,,1,
- net,,,20,,,,,,,,,,,,,,,,,,,,20,
- net/http,2,16,22,,,,,,1,,,,,,,,1,,,,,16,22,
+ net,2,16,100,,,,,,1,,,,,,,,1,,,,,16,100,
- net/http/httputil,,,10,,,,,,,,,,,,,,,,,,,,10,
- net/mail,,,6,,,,,,,,,,,,,,,,,,,,6,
- net/textproto,,,19,,,,,,,,,,,,,,,,,,,,19,
- net/url,,,23,,,,,,,,,,,,,,,,,,,,23,
- os,27,10,6,1,,,,,26,,,,,,,,,,,7,3,,6,
+ os,29,10,6,3,,,,,26,,,,,,,,,,,7,3,,6,
- os/exec,2,,,2,,,,,,,,,,,,,,,,,,,,
- path,,,5,,,,,,,,,,,,,,,,,,,,5,
+ path,,,18,,,,,,,,,,,,,,,,,,,,18,
- path/filepath,,,13,,,,,,,,,,,,,,,,,,,,13,
- sync,,,10,,,,,,,,,,,,,,,,,,,,10,
+ sync,,,34,,,,,,,,,,,,,,,,,,,,34,
- sync/atomic,,,24,,,,,,,,,,,,,,,,,,,,24,

@owen-mc owen-mc marked this pull request as ready for review August 22, 2024 11:10
@owen-mc owen-mc requested a review from a team as a code owner August 22, 2024 11:10
@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Aug 22, 2024
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible

@owen-mc owen-mc merged commit 18b99ff into github:main Aug 22, 2024
14 of 15 checks passed
@owen-mc owen-mc deleted the go/fix-frameworks-coverage branch August 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants