Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Improve guardingFunction join order #17238

Closed
wants to merge 2 commits into from
Closed

Go: Improve guardingFunction join order #17238

wants to merge 2 commits into from

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Aug 15, 2024

No description provided.

@github-actions github-actions bot added the Go label Aug 15, 2024
@smowton smowton marked this pull request as ready for review August 15, 2024 17:21
@smowton smowton requested a review from a team as a code owner August 15, 2024 17:21
aschackmull
aschackmull approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably isn't optimal, but it improves the observed bad case substantially.

Edit: Sorry, didn't see the dca slowdown. I guess this isn't good enough after all.

@smowton
Copy link
Contributor Author

smowton commented Oct 9, 2024

Two guardingFunction ordering issues were resolved in #17357 with broadly positive and sometimes huge performance consequences.

@smowton smowton closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees
No one assigned
Labels
Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smowton @aschackmull