Update CookieInjection.ql to remove period from @name #17234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicitymay
added
the
no-change-note-required
joefarebrother
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@nameattribute for queries should not end with a period, see Query metadata style guide.This PR removes the period from the name. As far as I can tell, this is the only place where the update needs to be made.
Ideally this would be picked up by a linter or reviewer before it generates a linter error in the Docs repository, but it doesn't happen very often 🙂
👋🏻 One process consideration. When a team promotes an experimental query into the default packs, it would make sense to ask for a review by the Docs team since we don't review the user-facing content for experimental queries when they are added to the repository.