Ruby: Rework (hash) splat argument/parameter matching #17222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
ruby/hash-splat-param-arg-matching
branch
2 times, most recently
from
b6fe05b to
3ca4888
Compare
asgerf
reviewed
Aug 20, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1492
to
+1494
| any(SynthSplatArgumentShiftNode shift | | ||
| shift = TSynthSplatArgumentShiftNode(_, actualSplat, _) | ||
| ).storeInto(this, _) |
Check warning
Code scanning / CodeQL
Expression can be replaced with a cast Warning
hvitved
force-pushed
the
ruby/hash-splat-param-arg-matching
branch
from
185836e to
f0c761a
Compare
|
I have pushed two new commits:
|
hvitved
force-pushed
the
ruby/hash-splat-param-arg-matching
branch
from
f0c761a to
d15e1b5
Compare
|
A note on the additional results reported by DCA: The DCA run before c4b0f81 (which removes some false positive flow) shows a bunch of new results. This is because we now correctly identify more true positive flow, as witnessed by the test added in the last commit (which would fail on |
Ahadchogani
reviewed
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @asgerf's PR, this PR rewrites the logic for how Ruby handles splat arguments and parameters. Instead of using a separate
Contenttype to perform the matching, we make use of different argument/parameter positions in order to prevent synthetic splat arguments from being matched with synthetic splat parameters.Not only does this rewrite simplify the code, we also get a significant speedup (12% end-to-end analysis speedup on average). This is because the early data flow pruning stages have precise argument/parameter position matching, wheres precise content matching only happens in later pruning stages.