-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Swift integration tests to pytest. #17178
Conversation
ec4ba6a
to
2e1bc46
Compare
2e1bc46
to
e5261f8
Compare
I'm seeing the following test failure:
I have no idea why this triggers on the pytest port, but not on the original branch. |
I think those tests are unfortunately sensible to what runner runs them, so it might just be a question of having changed that moving to the integration test check template. We can just accept the change, or put some effort into making the test a bit less host dependent, like skipping some of the entries in the query. Unfortunately testing |
The query already skips Builtin.FPIEEE16, so I'd be happy to also skip Builtin.FPIEEE80 there too. I'll check if we moved from intel to arm macs here, as Builtin.FPIEEE80 sounds very much like an x86_64 thing, it'd make sense if it disappears there. |
This way, we have at least one Windows test, which makes our internal testing easier.
Tests pass on this PR due to a test infrastructure failure, they ought to fail.
Apparently some test databases have DB-check failures, instead of blanket-disabling db-checks for Swift, I've marked these tests now manually.