Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Support Go 1.23 (Explicit aliases) #17058

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Go: Support Go 1.23 (Explicit aliases) #17058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e604749
Go: Use 1.23 in build process
mbg Jul 24, 2024
299b2e4
Go: Use 1.23 in tests
mbg Jul 24, 2024
6b1bd05
Go: Use 1.23 for extractor
mbg Jul 24, 2024
1192564
Go: Update frontend error messages for Go 1.23
mbg Jul 24, 2024
f4b3dfc
Go: Update dbscheme for aliases
mbg Aug 16, 2024
bbe2406
Go: Extract type aliases
mbg Aug 16, 2024
cd7cf4f
Go: Add database upgrade/downgrades for type aliases
mbg Aug 16, 2024
91946de
Go: Extract alias names
mbg Aug 16, 2024
221bab7
Go: Add test for `AliasType` extraction
mbg Aug 16, 2024
47ad284
Go: Fix formatting and documentation of `AliasType`
mbg Aug 16, 2024
90068f6
Go: Update `AliasType` to implement `getUnderlyingType`
mbg Aug 19, 2024
5797dba
Go: Extract objects for aliases
mbg Aug 19, 2024
191f712
Go: Update test for aliases to print immediate RHS and underlying type
mbg Aug 19, 2024
76e27ff
Go: Remove `alias_rhs` table in downgrade script
mbg Aug 19, 2024
77cf0ac
Go: add patch for go 1.23 windows build problem
Aug 21, 2024
f6e577e
Factor out `extractTypeObject`
owen-mc Aug 21, 2024
3a8a7ea
Fix alias use in HTML template escaping passthrough
owen-mc Aug 20, 2024
7589186
Use unique type param names in test
owen-mc Aug 20, 2024
a6557fc
Accept test change related to alias types
owen-mc Aug 20, 2024
9ca7536
Update underlying type of alias
owen-mc Aug 21, 2024
f2695d0
Fix syntax error in test
owen-mc Aug 21, 2024
23d1dfa
Delete more about alias types in downgrade script
owen-mc Aug 21, 2024
bd89eb0
Improve `AliasType.getUnderlyingType`
owen-mc Aug 21, 2024
649bf5a
Improve Aliases test
owen-mc Aug 21, 2024
fe6d364
Update labels for alias types
owen-mc Aug 22, 2024
da12b33
Add change note
owen-mc Aug 22, 2024
e660b85
Update max supported Go version to 1.23
owen-mc Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ local_path_override(
# see https://registry.bazel.build/ for a list of available packages

bazel_dep(name = "platforms", version = "0.0.10")
bazel_dep(name = "rules_go", version = "0.49.0")
bazel_dep(name = "rules_go", version = "0.49.0-codeql.1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that https://github.com/bazelbuild/rules_go/releases/tag/v0.50.0 has been released, can we just use that?
This also means we can remove the 0.49.0-codeql.1 release from the registry (also added in this PR).

Copy link
Member Author

@mbg mbg Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting us know 👍🏻 I'll drop @redsun82's fix in the next rebase and bump this to the new version instead.

bazel_dep(name = "rules_pkg", version = "0.10.1")
bazel_dep(name = "rules_nodejs", version = "6.2.0-codeql.1")
bazel_dep(name = "rules_python", version = "0.32.2")
Expand Down Expand Up @@ -153,7 +153,7 @@ use_repo(
)

go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
go_sdk.download(version = "1.22.2")
go_sdk.download(version = "1.23.0")

go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps")
go_deps.from_file(go_mod = "//go/extractor:go.mod")
Expand Down
2 changes: 1 addition & 1 deletion docs/codeql/reusables/supported-versions-compilers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
.NET Core up to 3.1

.NET 5, .NET 6, .NET 7, .NET 8","``.sln``, ``.csproj``, ``.cs``, ``.cshtml``, ``.xaml``"
Go (aka Golang), "Go up to 1.22", "Go 1.11 or more recent", ``.go``
Go (aka Golang), "Go up to 1.23", "Go 1.11 or more recent", ``.go``
Java,"Java 7 to 22 [5]_","javac (OpenJDK and Oracle JDK),

Eclipse compiler for Java (ECJ) [6]_",``.java``
Expand Down
2 changes: 1 addition & 1 deletion go/actions/test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inputs:
go-test-version:
description: Which Go version to use for running the tests
required: false
default: ~1.22.0
default: "1.23.0"
run-code-checks:
description: Whether to run formatting, code and qhelp generation checks
required: false
Expand Down
Loading
Loading