Shared: Add support for provenance pretty-printing as a qltest postprocess step. #17011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
owen-mc
reviewed
Jul 18, 2024
|
|
||
| external predicate queryRelations(string relation); | ||
|
|
||
| query predicate resultRelations(string relation) { queryRelations(relation) } |
There was a problem hiding this comment.
I don't understand why we need this line. I assume it's linked to the post-processing.
There was a problem hiding this comment.
It is. It basically ensures that we keep any empty tables instead of discarding them (so this mostly applies to the subpaths predicate).
aschackmull
force-pushed
the
dataflow/provenance-postprocess-qltest
branch
from
884eff6 to
94078e8
Compare
owen-mc
reviewed
Jul 18, 2024
owen-mc
approved these changes
Jul 26, 2024
|
An integration test kept on failing, so I merged in |
|
@aschackmull I believe this is ready to be merged now 🎉 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #16210. With post-processing of qltest output we can now do this in a much nicer way.