Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg.bzl: Disable remote caching of zipmerge steps. #17010

Merged
merged 1 commit into from
Jul 18, 2024
Merged

pkg.bzl: Disable remote caching of zipmerge steps. #17010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions misc/bazel/pkg.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,16 @@ def _zipmerge_impl(ctx):
executable = ctx.executable._zipmerge,
inputs = depset(zips, transitive = transitive_zips),
arguments = args,
# Disable remote caching for zipmerge:
# * One of the inputs to zipmerge (often the larger one) comes from a lazy-lfs rule.
# Those are retrieved by bazel even in the presence of a build cache, so downloading the whole zipmerged
# artifact is slower than downloading the smaller bazel-produced zip and rerunning zipmerge on that
# and the (already-present) LFS artifact.
# * This prevents unnecessary cache usage - every change to the Swift extractor would otherwise
# trigger a build of a >500MB zip file that'd quickly fill up the cache.
execution_requirements = {
"no-remote-cache": "1",
},
)

return [
Expand Down
Loading