Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go/Bazel: use gazelle go_deps instead of a vendor directory #16987

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

redsun82
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Go label Jul 16, 2024
require (
golang.org/x/mod v0.15.0
golang.org/x/mod v0.16.0
Copy link
Contributor Author

@redsun82 redsun82 Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was suggested to me by go mod tidy

@redsun82 redsun82 marked this pull request as ready for review July 16, 2024 14:40
@redsun82 redsun82 requested review from a team as code owners July 16, 2024 14:40
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together! This looks good to me. I have checked that this works with both make in ql/go and a Bazel build from the internal repo.

@redsun82 redsun82 merged commit bf69c76 into main Jul 17, 2024
23 checks passed
@redsun82 redsun82 deleted the redsun82/go branch July 17, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants